i#4719 qemu: Add -ignore_takeover_timeout #4725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a maximum tries when waiting for a thread to be taken over at initialization time, instead of looping forever. When the max is hit, a fatal error is raised, unless a newly added option -ignore_takeover_timeout is set. The new option is used to ignore QEMU's own thread when running DR under QEMU. QEMU is not fully transparent and unfortunately does not hide its thread from DR in procfs. Manually tested both option settings under QEMU. Regression tests with QEMU are planned for the test suite for ARM. Issue: #4719
sapostolakis
approved these changes
Feb 9, 2021
derekbruening
added a commit
that referenced
this pull request
Feb 10, 2021
Fixes a problem with the hardcoded small timeout from PR #4725 by parameterizing the timeout in a new option -takeover_timeout_ms. It is set to a high value by default; the plan is to have -xarch_root set it to a low value for the common QEMU case of running a small test, while still overridable for large apps. Renames -ignore_takeover_timeout to -unsafe_ignore_takeover_timeout to indicate that it can cause problems if actual application threads are left native. Issue: #4719
derekbruening
added a commit
that referenced
this pull request
Feb 10, 2021
Fixes a problem with the hardcoded small timeout from PR #4725 by parameterizing the timeout in a new option -takeover_timeout_ms. It is set to a high value by default; the plan is to have -xarch_root set it to a low value for the common QEMU case of running a small test, while still overridable for large apps. Renames -ignore_takeover_timeout to -unsafe_ignore_takeover_timeout to indicate that it can cause problems if actual application threads are left native. Issue: #4719
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a maximum tries when waiting for a thread to be taken over at
initialization time, instead of looping forever. When the max is hit,
a fatal error is raised, unless a newly added option
-ignore_takeover_timeout is set.
The new option is used to ignore QEMU's own thread when running DR
under QEMU. QEMU is not fully transparent and unfortunately does not
hide its thread from DR in procfs.
Manually tested both option settings under QEMU. Regression tests
with QEMU are planned for the test suite for ARM.
Issue: #4719